Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Fix setting component name and attributes #32599

Merged
merged 4 commits into from
Apr 29, 2020
Merged

[7.x] Fix setting component name and attributes #32599

merged 4 commits into from
Apr 29, 2020

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Apr 29, 2020 •
edited
Loading

This PR fixes setting the component alias and attributes so they can be used within the render method of a component.

@driesvints driesvints marked this pull request as draft April 29, 2020 15:35
@driesvints driesvints changed the title [7.x] Fix setting component name [7.x] Fix setting component name and attributes Apr 29, 2020
@driesvints driesvints force-pushed the fix-setting-component-name branch from 9226754 to cf9b171 Compare April 29, 2020 16:17
@driesvints driesvints marked this pull request as ready for review April 29, 2020 16:20
@driesvints driesvints force-pushed the fix-setting-component-name branch from cf9b171 to 7834fe3 Compare April 29, 2020 16:23
@taylorotwell taylorotwell merged commit cb523c7 into 7.x Apr 29, 2020
@driesvints driesvints deleted the fix-setting-component-name branch April 29, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driesvints @taylorotwell